Skip to content

feat: make UI kit tooltips accessible #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xMort
Copy link
Contributor

@xMort xMort commented Feb 7, 2025

  • set appropriate aria props
  • display tooltip on hover, hide on blur
  • allow to focus and navigate in interactive tooltips
  • dismiss the tooltips with ESC

JIRA: LX-560, LX-726
risk: low


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

- set appropriate aria props
- display tooltip on hover, hide on blur
- allow to focus and navigate in interactive tooltips
- dismiss the tooltips with ESC

JIRA: LX-560, LX-726
risk: low
@xMort xMort requested a review from kandl as a code owner February 7, 2025 15:42
@xMort xMort added the do not merge Do not merge this yet label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant